Conversation
laeubi
force-pushed
the
update_verifier
branch
from
f5f7bc2 to
c9abdc1
Compare
Test Results1 041 files ±0 1 041 suites ±0 5h 0m 9s ⏱️ - 16m 8s For more details on these failures and errors, see this check. Results for commit 28daf51. ± Comparison against base commit 91ff807. ♻️ This comment has been updated with latest results. |
|
I got the verifier update successful now with only a few exceptions, so if anyone like to help with this it would be welcome, at the moment I have no idea what can cause this maybe something with passing the arguments. |
laeubi
force-pushed
the
update_verifier
branch
3 times, most recently
from
23cadcd to
a808807
Compare
|
@akurtakov maybe something you can help with as well after M1? I got most things fixed now but there are 5 failing test left after the upgrade to Maven Verifier 2.x I just don't understand what might cause this change in behavior .. but probably we just see a bug here that was not discovered previously? The most notable changes for Verifier 2.x is that method names changed and arguments are no longer parsed and passed "as is" but I can't see why it should make a difference here, still a second pair of eyes might reveal something. Next thing is that Verifier 2 executes in the same process by default instead of forking, I have disabled that so we always fork because some test don't work well with it, so it should not be an issue here. |
|
I have the will but no promises :) |
akurtakov
force-pushed
the
update_verifier
branch
from
a808807 to
7e38006
Compare
laeubi
force-pushed
the
update_verifier
branch
2 times, most recently
from
78702e6 to
bc68ade
Compare
|
Rebased... |
|
Maybe one should first finish this one as a smaller increment: |
|
@dependabot rebase |
This is not a dependabot PR ;-) I can try to rebase this and resolve conflicts but last time there where still some testfailures du to the upgrade so someone must be look into this if we want to upgrade. |
|
I would probably not find time to look into it as it's just M1 but I'll try to handle some of the deprecations done in this PR separately so it becomes less of a churn. |
laeubi
force-pushed
the
update_verifier
branch
from
48bcc22 to
aac5d3a
Compare
Migrate from maven-verifier 1.8.0 to 2.0.0-M1: - Update package imports from org.apache.maven.it to org.apache.maven.shared.verifier - Rename addCliOption() to addCliArgument() - Split compound arguments (-s, --toolchains) into addCliArguments() - Split customOptions string into array for addCliArguments() - Rename assertArtifactContents() to verifyArtifactContent()
Maven Verifier 2.x no longer parses compound CLI arguments. Split all
addCliArgument("option value") calls into addCliArguments("option", "value")
in AbstractTychoIntegrationTest, MavenReactorMakeOptionsTest, and
TychoVersionsPluginTest.
No description provided.