Skip to content

CallHierarchyService Plugin API #3765 #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CallHierarchyService Plugin API #3765 #4146

wants to merge 1 commit into from

Conversation

@vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented Jan 22, 2019

Issue #3765

Signed-off-by: Victor Rubezhny [email protected]

@AlexTugarev
Copy link
Contributor

AlexTugarev commented Jan 23, 2019

Hi @vrubezhny! 'Just discovered this PR using the initially proposed calls protocol extension.

Recently I've updated the protocol proposal as requested. Please have a look and align.

A dev release of the TS LS implementing the updated callHierarchy protocol is published as well. The update for Theia callhierarchy extension is in progress.

@vrubezhny
Copy link
Contributor Author

vrubezhny commented Jan 23, 2019 •
edited
Loading

Hi @AlexTugarev !

I'll take a look/ Thank you for let me notest!

@vrubezhny
CallHierarchyService Plugin API #3765
6fb1157 
Issue #3765

Signed-off-by: Victor Rubezhny <[email protected]>
@tsmaeder
Copy link
Member

tsmaeder commented Aug 14, 2019

@benoitf @evidolob @AlexTugarev ping?

@tsmaeder tsmaeder mentioned this pull request Aug 14, 2019
Closed
24 tasks
@AlexTugarev
Copy link
Contributor

AlexTugarev commented Aug 14, 2019 •
edited
Loading

microsoft/vscode-languageserver-node#420 was accepted 🎉 , so it would make sense to update. same applies to #4154 btw 😞

@akosyakov akosyakov added the plug-in system issues related to the plug-in system label Aug 14, 2019
akosyakov
akosyakov reviewed Aug 14, 2019
View reviewed changes
packages/plugin/src/theia.d.ts
* @param service A call hierarchy provider.
* @return A [disposable](#Disposable) that unregisters this provider when being disposed.
*/
export function registerCallHierarchyProvider(selector: DocumentSelector, provider: CallHierarchyProvider): Disposable;
Copy link
Member

@akosyakov akosyakov Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it proposed api? Please move it theia.proposed.d.ts

Copy link
Member

@akosyakov akosyakov Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should copy it from here: https://github.com/microsoft/vscode-languageserver-node/blob/51ce5233b6f97a4e2b6bee8f729205774a243140/client/src/callHierarchy.proposed.ts#L185-L234

Please don't forget a CQ. ping @theia-ide/ip-help if you need any help with it

@svor svor mentioned this pull request Jan 11, 2020
Closed
@benoitf benoitf mentioned this pull request Jan 28, 2020
Merged
1 task
@tsmaeder tsmaeder closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoitf benoitf Awaiting requested review from benoitf

@evidolob evidolob Awaiting requested review from evidolob

1 more reviewer

@akosyakov akosyakov akosyakov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plug-in system issues related to the plug-in system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vrubezhny @AlexTugarev @tsmaeder @akosyakov