Skip to content

fix some localization#11629

Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
yiliang114:zh-cn-localization
Sep 27, 2022
Merged

fix some localization#11629
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
yiliang114:zh-cn-localization

Conversation

@yiliang114
Copy link
Copy Markdown
Contributor

What it does

fix some localization

How to test

  1. Start App and Switch 中文(简体) zh-cn language
  2. Click Extension activity bar and search some extensions what ever.
  3. Hover your cursor and check out it's tooltips.
  4. Check out the translation of the copy extension Id.

Review checklist

Reminder for reviewers

before:
image

after:
image

@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Sep 2, 2022
@colin-grant-work colin-grant-work self-requested a review September 2, 2022 21:39
Copy link
Copy Markdown
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks as always!

Copy link
Copy Markdown
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last comment was meant to be an approval, and this is actually an approval.

@colin-grant-work colin-grant-work merged commit 22a5f7e into eclipse-theia:master Sep 27, 2022
@colin-grant-work colin-grant-work added this to the 1.30.0 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localization issues related to localization/internalization/nls

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants