Skip to content

Standardized Plugins Downloads and Center Icons #11494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vince-fugnitto merged 9 commits into from
Aug 8, 2022
Merged

Standardized Plugins Downloads and Center Icons #11494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f964a3d
fix(vsx-registry): Standardized Plugins Download Numbers and Center I…
yiliang114 Aug 2, 2022
d45563a
fix(vsx-registry): Standardized Extension AverageRating
yiliang114 Aug 2, 2022
dc39b6c
Update packages/vsx-registry/src/browser/vsx-extension.tsx
yiliang114 Aug 3, 2022
c150f6a
fix(vsx-registry): simplified function and supplementary translation
yiliang114 Aug 3, 2022
f46789c
Merge branch 'master' of https://github.com/eclipse-theia/theia
yiliang114 Aug 3, 2022
5f8967b
Update packages/vsx-registry/src/browser/vsx-extension.tsx
yiliang114 Aug 4, 2022
05cd59c
Merge branch 'master' of https://github.com/eclipse-theia/theia
yiliang114 Aug 4, 2022
922358a
Merge branch 'master' of https://github.com/yiliang114/theia
yiliang114 Aug 4, 2022
4599a5a
fix(vsx-registry): localiztion of tooltips
yiliang114 Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/vsx-registry/src/browser/style/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@
font-size: 110%;
}

.theia-vsx-extension-content .title .stat .download-count,
.theia-vsx-extension-content .title .stat .average-rating {
display: inline-flex;
align-items: center;
}

.theia-vsx-extension-content .title .stat .average-rating > i {
color: #ff8e00;
}
Expand Down
22 changes: 14 additions & 8 deletions packages/vsx-registry/src/browser/vsx-extension.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,18 +271,18 @@ export class VSXExtension implements VSXExtensionData, TreeElement {
}

get tooltip(): string {
let md = `__${this.displayName}__ ${VSXExtension.formatVersion(this.version)}\n\n${this.description}\n_____\n\nPublisher: ${this.publisher}`;
let md = `__${this.displayName}__ ${VSXExtension.formatVersion(this.version)}\n\n${this.description}\n_____\n\n${nls.localizeByDefault('Publisher: {0}', this.publisher)}`;

if (this.license) {
md += ` \rLicense: ${this.license}`;
md += ` \r${nls.localize('theia/vsx-registry/license', 'License: {0}', this.license)}`;
}

if (this.downloadCount) {
md += ` \rDownload count: ${downloadCompactFormatter.format(this.downloadCount)}`;
md += ` \r${nls.localize('theia/vsx-registry/downloadCount', 'Download count: {0}', downloadCompactFormatter.format(this.downloadCount))}`;
}

if (this.averageRating) {
md += ` \rAverage Rating: ${this.averageRating.toFixed(1)}`;
md += ` \r${getAverageRatingTitle(this.averageRating)}`;
}

return markdownit().render(md);
Expand Down Expand Up @@ -443,7 +443,10 @@ export namespace AbstractVSXExtensionComponent {

const downloadFormatter = new Intl.NumberFormat();
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const downloadCompactFormatter = new Intl.NumberFormat(undefined, { notation: 'compact', compactDisplay: 'short' } as any);
const downloadCompactFormatter = new Intl.NumberFormat('en-US', { notation: 'compact', compactDisplay: 'short' } as any);
const averageRatingFormatter = (averageRating: number): number => Math.round(averageRating * 2) / 2;
const getAverageRatingTitle = (averageRating: number): string =>
nls.localize('theia/vsx-registry/averageRating', 'Average rating: {0} out of 5', averageRatingFormatter(averageRating));

export namespace VSXExtensionComponent {
export interface Props extends AbstractVSXExtensionComponent.Props {
Expand All @@ -466,7 +469,7 @@ export class VSXExtensionComponent<Props extends VSXExtensionComponent.Props = V
</div>
<div className='stat'>
{!!downloadCount && <span className='download-count'><i className={codicon('cloud-download')} />{downloadCompactFormatter.format(downloadCount)}</span>}
{!!averageRating && <span className='average-rating'><i className={codicon('star-full')} />{averageRating.toFixed(1)}</span>}
{!!averageRating && <span className='average-rating'><i className={codicon('star-full')} />{averageRatingFormatter(averageRating)}</span>}
</div>
</div>
<div className='noWrapInfo theia-vsx-extension-description'>{description}</div>
Expand Down Expand Up @@ -516,7 +519,10 @@ export class VSXExtensionEditorComponent extends AbstractVSXExtensionComponent {
</span>
{!!downloadCount && <span className='download-count' onClick={this.openExtension}>
<i className={codicon('cloud-download')} />{downloadFormatter.format(downloadCount)}</span>}
{averageRating !== undefined && <span className='average-rating' onClick={this.openAverageRating}>{this.renderStars()}</span>}
{
averageRating !== undefined &&
<span className='average-rating' title={getAverageRatingTitle(averageRating)} onClick={this.openAverageRating}>{this.renderStars()}</span>
}
{repository && <span className='repository' onClick={this.openRepository}>Repository</span>}
{license && <span className='license' onClick={this.openLicense}>{license}</span>}
{version && <span className='version'>{VSXExtension.formatVersion(version)}</span>}
Expand All @@ -527,7 +533,7 @@ export class VSXExtensionEditorComponent extends AbstractVSXExtensionComponent {
</div>
{
sanitizedReadme &&
< div className='scroll-container'
<div className='scroll-container'
style={scrollStyle}
ref={ref => this._scrollContainer = (ref || undefined)}>
<div className='body'
Expand Down