Skip to content

add indent_size for tsx in .editorconfig#11380

Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
yiliang114:fix/tsx-editorconfig
Jul 5, 2022
Merged

add indent_size for tsx in .editorconfig#11380
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
yiliang114:fix/tsx-editorconfig

Conversation

@yiliang114
Copy link
Copy Markdown
Contributor

Signed-off-by: yiliang114 1204183885@qq.com

What it does

  1. set the indent size of tsx file 4.

How to test

  1. open theia source code in editor such as vscode or webstorm.
  2. open any tsx file, change and save
  3. eslint will not make this tsx file to be 2 indent_size.

Review checklist

Reminder for reviewers

Signed-off-by: yiliang114 <1204183885@qq.com>
@yiliang114
Copy link
Copy Markdown
Contributor Author

If not, it will cause such problem when we trigger autoFixOnSave

image

@colin-grant-work colin-grant-work self-requested a review July 5, 2022 15:09
Copy link
Copy Markdown
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍

@colin-grant-work colin-grant-work merged commit 97ce5f8 into eclipse-theia:master Jul 5, 2022
@vince-fugnitto vince-fugnitto added the contributor experience issues related to the contributor experience label Jul 28, 2022
@vince-fugnitto vince-fugnitto added this to the 1.28.0 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor experience issues related to the contributor experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants