vertical center icons in getting started (#11369)#11370
Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom Jun 29, 2022
Merged
vertical center icons in getting started (#11369)#11370colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
Conversation
Signed-off-by: yiliang114 <[email protected]>
colin-grant-work
approved these changes
Jun 29, 2022
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
The change achieves its objective and is scoped narrowly to produce no regressions. 👍
Contributor
Author
Thanks for your review. |
vince-fugnitto
added
the
getting-started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yiliang114 [email protected]
What it does
Just vertical center icons in getting started.
How to test
Cmd+Shift+Pcall outCommand Palette.Getting Startedto openGetting StartedTab.before:
after:
Review checklist
Reminder for reviewers