Refactor/rename messaging contribution push param

[harbin1053020115]

What it does

Rename message-contirbution.ts(packages/core/src/node/messaging/messaging-contribution.ts) ConnectionHandlers.push param, which is changing channel to socket.

How to test

No need to test.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

I'm not sure I fully understand the reasons for the change, it is only updating the variable name in the callback, uses of MessagingContribution.push still use channel (verified with find all references).

[harbin1053020115]

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

I'm not sure I fully understand the reasons for the change, it is only updating the variable name in the callback, uses of MessagingContribution.push still use channel (verified with find all references).

The original channel param name is misunderstanding with the channel concept in MessagingContribution.handleChannels method, but actually it means socket.

[vince-fugnitto]

The original channel param name is misunderstanding with the channel concept in MessagingContribution.handleChannels method, but actually it means socket.

I believe socket might also be confusing since it accepts any generic connection (likely the best name).
Currently we have WebSocketChannel and Socket that make use of ConnectionHandlers:

theia/packages/core/src/node/messaging/messaging-contribution.ts

Line 55 in 3893fde

protected readonly wsHandlers = new MessagingContribution.ConnectionHandlers<Socket>();

theia/packages/core/src/node/messaging/messaging-contribution.ts

Line 56 in 3893fde

protected readonly channelHandlers = new MessagingContribution.ConnectionHandlers<WebSocketChannel>();

theia/packages/core/src/electron-main/messaging/electron-messaging-contribution.ts

Line 46 in 3893fde

protected readonly channelHandlers = new MessagingContribution.ConnectionHandlers<WebSocketChannel>();

[harbin1053020115]

so, if this is meaningful:

push(spec: string, callback: (params: MessagingService.PathParams, connection: T) => void): void {
    const route = new Route(spec);
    // here is the change, or you can look at the lastest changes.
    this.handlers.push((path, channel: T) => {
        const params = route.match(path);
        if (!params) {
            return false;
        }
        callback(params, channel);
        return route.reverse(params);
    });
}

[vince-fugnitto]

I don't see the value in this change?

We can already infer the type from handlers:

protected readonly handlers: ((path: string, connection: T) => string | false)[] = [];

and the editor gives us hover information that channel is of type T.

---

What exactly is the change attempting to achieve?

[harbin1053020115]

I see, please ignore this pr

[vince-fugnitto]

No problem! If there are improvements or features you'd like to work on please don't hesitate to contribute and we'd be happy to review them :)