Skip to content

refactor: rename ConnectionHandlers.push param in packages/core/src/node/messaging/messaging-contribution.ts#10994

Closed
harbin1053020115 wants to merge 1 commit intoeclipse-theia:masterfrom
harbin1053020115:refactor/rename-messaging-contribution-push-param
Closed

refactor: rename ConnectionHandlers.push param in packages/core/src/node/messaging/messaging-contribution.ts#10994
harbin1053020115 wants to merge 1 commit intoeclipse-theia:masterfrom
harbin1053020115:refactor/rename-messaging-contribution-push-param

Conversation

@harbin1053020115
Copy link
Copy Markdown

@harbin1053020115 harbin1053020115 commented Apr 6, 2022

What it does

Rename message-contirbution.ts(packages/core/src/node/messaging/messaging-contribution.ts) ConnectionHandlers.push param, which is changing channel to socket.

How to test

no need to test

Review checklist

Reminder for reviewers

@harbin1053020115 harbin1053020115 changed the title refactor: rename MessagingContribution.push param refactor: rename ConnectionHandlers.push param in packages/core/src/node/messaging/messaging-contribution.ts Apr 6, 2022
@harbin1053020115
Copy link
Copy Markdown
Author

In MessageContribution

push(spec: string, callback: (params: MessagingService.PathParams, connection: T) => void): void {
      const route = new Route(spec);
      this.handlers.push((path, channel) => {
          const params = route.match(path);
          if (!params) {
              return false;
          }
          callback(params, channel);
          return route.reverse(params);
      });
  }

@harbin1053020115 harbin1053020115 deleted the refactor/rename-messaging-contribution-push-param branch April 6, 2022 11:09
@harbin1053020115 harbin1053020115 restored the refactor/rename-messaging-contribution-push-param branch April 6, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants