ClipboardForm: add menu to copy text by mouse#2037
Open
bschwarzent wants to merge 1 commit intoreleases/26.1from
Open
ClipboardForm: add menu to copy text by mouse#2037bschwarzent wants to merge 1 commit intoreleases/26.1from
bschwarzent wants to merge 1 commit intoreleases/26.1from
Conversation
In addition to pressing ctrl-c or using the context menu, the user can now also click the "copy" menu to copy the selected text to the clipboard. The copy menu is shown instead of the normal ok button when the form is in "copy" mode. The cancel button is now always visible so the form can be closed without copying anything. The text is computed by the new method ClipboardField#getSelectedText. Additional changes: - ClipboardForm: cleanup some clipboard related texts. - ClipboardForm: make instruction label non-selectable, just like any other form field label. - ClipboardField: prevent default action for all potentially destructive keystrokes to give the impression of a "readonly" input field. The field is not generally marked as disabled because in "paste" mode, the paste action must be possible. The event is _not_ stopped from bubbling up to the form, because the form might still use some of the keystrokes (e.g. ENTER to close the form). - Use same dialog size in "copy" and "paste" mode. 378797
bschwarzent
force-pushed
the
features/bsh/26.1/378797_copy_menu
branch
from
d51f09e to
29c8b88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of pressing ctrl-c or using the context menu, the user can now also click the "copy" menu to copy the selected text to the clipboard.
Additional changes:
378797