Table: prevent error when hierarchical table contains orphaned rows#1681
Open
bschwarzent wants to merge 1 commit intoreleases/24.2from
Open
Table: prevent error when hierarchical table contains orphaned rows#1681bschwarzent wants to merge 1 commit intoreleases/24.2from
bschwarzent wants to merge 1 commit intoreleases/24.2from
Conversation
When table data is hierarchical, rows can define other rows as their parent. If that reference is invalid (i.e. a key that does not exist), an error was thrown in Table#rebuildTreeStructureInternal. This causes the table to be unusable for the user. Because invalid parent references can happen due to row limits, we should handle this case more gracefully. The easiest solution is to simply add a row filter that hides such orphaned rows. 301956
bschwarzent
force-pushed
the
features/bsh/24.2/301956_table_orphan_rows
branch
from
5a57b42 to
f130773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When table data is hierarchical, rows can define other rows as their parent. If that reference is invalid (i.e. a key that does not exist), an error was thrown in Table#rebuildTreeStructureInternal. This causes the table to be unusable for the user. Because invalid parent references can happen due to row limits, we should handle this case more gracefully. The easiest solution is to simply add a row filter that hides such orphaned rows.
301956