Skip to content

Add jdk26 MemoryMXBean.getTotalGcCpuTime() implementation, remove some unnecessary OpenJ9 classes #22972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add jdk26 MemoryMXBean.getTotalGcCpuTime() implementation, remove some unnecessary OpenJ9 classes #22972

wants to merge 2 commits into from

Conversation

@pshipton
Copy link
Member

@pshipton pshipton commented Nov 18, 2025 •
edited
Loading

Remove unnecessary MXBean related classes, interfaces, enums, classes that aren't OpenJ9 specific, are implemented in the extensions and don't need to be implemented by OpenJ9.

Closes #22967

@pshipton pshipton requested a review from keithc-ca November 18, 2025 19:46
@pshipton pshipton mentioned this pull request Nov 18, 2025
Closed
@pshipton pshipton changed the title Add MemoryMXBean.getTotalGcCpuTime() implementation, remove some unnecessary OpenJ9 classes Add jdk26 MemoryMXBean.getTotalGcCpuTime() implementation, remove some unnecessary OpenJ9 classes Nov 18, 2025
keithc-ca
keithc-ca requested changes Nov 18, 2025
View reviewed changes
@pshipton pshipton force-pushed the gccpu branch 3 times, most recently from d7412f8 to 37720e6 Compare November 19, 2025 03:05
@keithc-ca
Copy link
Contributor

keithc-ca commented Nov 19, 2025

Jenkins test sanity plinux jdk8,jdk21,jdknext

@keithc-ca
Copy link
Contributor

keithc-ca commented Nov 19, 2025

TestMemoryMXBean needs to be updated to expect the new API:

        FAILED: testGetMBeanInfo
        java.lang.AssertionError: 
        	at org.testng.AssertJUnit.fail(AssertJUnit.java:59)
        	at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:24)
        	at org.testng.AssertJUnit.assertTrue(AssertJUnit.java:33)
        	at org.openj9.test.java.lang.management.TestMemoryMXBean.testGetMBeanInfo(TestMemoryMXBean.java:743)

@pshipton
Remove unnecessary MXBean related class implementations
77dca19 
These classes, interfaces, enums, classes that aren't OpenJ9 specific,
are implemented in the extensions and don't need to be implemented by
OpenJ9.

Signed-off-by: Peter Shipton <[email protected]>
@pshipton
Add MemoryMXBean.getTotalGcCpuTime() implementation
02112cd 
Signed-off-by: Peter Shipton <[email protected]>
@pshipton
Copy link
Member Author

pshipton commented Nov 21, 2025

Updated TestMemoryMXBean, and rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithc-ca keithc-ca keithc-ca requested changes

Assignees

No one assigned

Labels

comp:vm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement MemoryMXBean.getTotalGcCpuTime() for Java 26+

2 participants

@pshipton @keithc-ca