Skip to content

Conversation

@laeubi
Copy link
Member

@laeubi laeubi commented Oct 18, 2025

Maven 4 will soon be released and should be able to execute Maven 3 projects as well. We should therefore upgrade m2e to use Maven 4 from now on.

For users that require Maven 3.9 line we can offer the latest 3.9.11 maven runtime as an additional install option like we already did for Maven 3.9.6

@github-actions
Copy link

github-actions bot commented Oct 18, 2025

Test Results

109 files   -   215  109 suites   - 215   18m 38s ⏱️ - 53m 18s
694 tests +    2  132 ✅  -   538  21 💤 ± 0  10 ❌ +10  531 🔥 +530 
740 runs   - 1 336  132 ✅  - 1 880  21 💤  - 42  10 ❌ +10  577 🔥 +576 

For more details on these failures and errors, see this check.

Results for commit 8aabf8e. ± Comparison against base commit 27eae6a.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the maven4_runtime branch 2 times, most recently from a954c36 to a953a87 Compare October 18, 2025 11:40
@laeubi
Copy link
Member Author

laeubi commented Oct 18, 2025

FYI @stbischof and @danthe1st as I know you are interested in Maven 4 support.

This at least already compiles ...

@stbischof
Copy link

Whooop whooop!!!!! Thank you a lot for your work

@laeubi
Copy link
Member Author

laeubi commented Oct 18, 2025

All tests are passing... except some of the flapping ones.

So that's already promising, and as there is discussions about release Maven 4 soon (finally, really!) I think we then can quite easily upgrade here.

So next logical step would be to create a Maven 4 testcase to see if maven features actually work!

@laeubi
Copy link
Member Author

laeubi commented Oct 18, 2025

We get a lot of deprecation warnings now but that is expected and we should fix those later on.
We maybe even just accept those for now to retain backward compatible for users that choose to use an older runtime.

One thing we need to check is if the new runtime is actually used for run the tests!

@laeubi
Copy link
Member Author

laeubi commented Oct 19, 2025

It seems I was a bit to optimistic here, while the runtime itself compiles, due to we include the old ones as well these where picked up, if I enforce Maven 4 runtime the test fails (see previous commit) and if I enforce it to be used for compilation there are also compile error... so we need to check if

  1. We can provide some "Compatibilty-Classes"
  2. We can only support Maven 3 or Maven 4 ... what would be a bit unfortunate given not all plugins/extensions are yet compatible with maven 4 and it is unclear if Maven 4 is really completely compatible.

@akurtakov
Copy link
Contributor

Wouldn't apache/maven#2380 supposed to help in this case?

@laeubi laeubi force-pushed the maven4_runtime branch 3 times, most recently from 1d41df7 to a177c2b Compare October 20, 2025 13:13
@laeubi
Copy link
Member Author

laeubi commented Oct 20, 2025

See also discussion here:

Maven 4 will soon be released and should be able to execute Maven 3
projects as well. We should therefore upgrade m2e to use Maven 4 from
now on.

For users that require Maven 3.9 line we can offer the latest 3.9.11
maven runtime as an additional install option like we already did for
Maven 3.9.6
@laeubi laeubi force-pushed the maven4_runtime branch 3 times, most recently from 25958be to f6c3302 Compare October 20, 2025 17:02
<target name="m2e-runtimes">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="slicer" includeSource="false" type="InstallableUnit">
<repository location="https://download.eclipse.org/technology/m2e/releases/2.2.1/"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old link should continue to work as there should automated redirect to the archive.

Comment on lines -26 to -29
<includes
id="org.eclipse.m2e.feature.source"
version="0.0.0"/>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to a separate PR?

@laeubi
Copy link
Member Author

laeubi commented Oct 21, 2025

@HannesWell this is currently only a draft so may contain some changes that must be cleaned up before a final version. I now have made it to compile again with Maven4 but possibly retain backwards compatible with Maven 3.9.x ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants