Skip to content

VertxHealthCheckEnricher nested enricher configuration does not work for Gradle Plugins #1649

@rohanKanojia

Description

@rohanKanojia

Component

JKube Kit

Task description

Description

Related to #1633

VertxHealthCheckEnricher seems to be having very unique enricher configuration. With Maven Plugins, users can provide nested configuration fields:

    <enricher>
      <config>
        <jkube-healthcheck-vertx>
            <readiness>
              <path>/ready</path>
            </readiness>
            <liveness>
              <path>/health</path>
            </liveness>
        </jkube-healthcheck-vertx>
      </config>
    </enricher>

We seem to reading plugin configuration as a map and then reading nested map values.

https://github.com/eclipse/jkube/blob/4cef8d361a73f04161699dd149383b70f60de6ca/jkube-kit/jkube-kit-vertx/src/main/java/org/eclipse/jkube/vertx/enricher/VertxHealthCheckEnricher.java#L342-L344

How plugin configuration would be fetched is defined here (right now it only works for maven):

https://github.com/eclipse/jkube/blob/4cef8d361a73f04161699dd149383b70f60de6ca/jkube-kit/enricher/api/src/main/java/org/eclipse/jkube/kit/enricher/api/JKubeEnricherContext.java#L92-L97

We need to evaluate this and see if we want to enable this behavior on Gradle as well.

Expected Behavior

Nested configuration should work for Gradle plugins too

Acceptance Criteria

  • Nested configuration works for VertxHealthCheckEnricher on Kubernetes Gradle Plugin
  • Documentation is updated with nested configuration examples

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingcomponent/gradle-pluginRelated to the Gradle Plugins

Type

No type
No fields configured for issues without a type.

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions