Skip to content

MicronautHealthCheckEnricher should also consider Micronaut Gradle Plugin in isApplicable #1634

@rohanKanojia

Description

@rohanKanojia

Component

JKube Kit

Task description

Description

MicronautHealthCheckEnricher has isApplicable method to check whether we should apply this enricher or not based on project dependencies:

https://github.com/eclipse/jkube/blob/61345823be63c73cf334649e33e9c5146f9d5f7a/jkube-kit/jkube-kit-micronaut/src/main/java/org/eclipse/jkube/micronaut/enricher/MicronautHealthCheckEnricher.java#L75-L79

It is not considering Micronaut Gradle Plugin. We should refactor this to use MicronautUtils.hasMicronautPlugin method which considers both cases:

-    if (!getContext().hasPlugin("io.micronaut.build", "micronaut-maven-plugin")) {
+    if (!hasMicronautPlugin(getContext().getProject())) {

Expected Behavior

Acceptance Criteria

  • Refactor isApplicable method to consider Micronaut Gradle Plugin
  • Port Micronaut health check documentation to gradle

Metadata

Metadata

Labels

bugSomething isn't workingcomponent/gradle-pluginRelated to the Gradle Plugins

Type

No type
No fields configured for issues without a type.

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions