property `jkube.enricher.jkube-controller.pullPolicy` is not taken into account if a `deployment` resource fragment is defined

[sunix]

Describe the bug

Trying to use jkube.enricher.jkube-controller.pullPolicy to set the image pull policy to Always. It works. However, once I added a deployment resource fragment, even not related, it stopped working.

Eclipse JKube version

1.8.0

Component

Kubernetes Maven Plugin

Apache Maven version

No response

Gradle version

No response

Steps to reproduce

1. Create a spring boot app from
2. Add the kubernetes maven plugin
3. Add in the pom.xml properties <jkube.enricher.jkube-controller.pullPolicy>Always</jkube.enricher.jkube-controller.pullPolicy>
4. mvn k8s:resource, the generated configuration with a pullpolicy to Always for the container image.
5. Add the file src/main/jkube/deployment.yml

spec:
  replicas: 2

7. mvn k8s:resource, the generated configuration with a pullpolicy to IfNotPresent for the container image.

Expected behavior

it should keep the pull policy to Always

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

other (please specify in additional context)

Environment

Linux

Eclipse JKube Logs

No response

Sample Reproducer Project

No response

Additional context

No response

[rohanKanojia]

I think it's not working because a different enricher ControllerViaPluginConfigurationEnricher gets executed when the user provides controller fragment.

I think it should work if you use this property instead:

jkube.enricher.jkube-controller-from-configuration.pullPolicy=Always

Related to fabric8io/fabric8-maven-plugin#401

[manusa]

So apparently we have at least 4 ways to control the pull policy (fragment, XML configuration, and 2 enricher peroperties).

We need to centralize where this configuration is computed and make sure it just works. (IIRC we did something similar for at least one other property).