Skip to content

iox-#2282 Fix website for v2.0.6 release notes#2285

Merged
elBoberido merged 4 commits into
eclipse-iceoryx:release_2.0from
elBoberido:iox-2282-fix-website-for-v-2-0-6
Apr 28, 2024
Merged

iox-#2282 Fix website for v2.0.6 release notes#2285
elBoberido merged 4 commits into
eclipse-iceoryx:release_2.0from
elBoberido:iox-2282-fix-website-for-v-2-0-6

Conversation

@elBoberido
Copy link
Copy Markdown
Member

@elBoberido elBoberido commented Apr 27, 2024

Notes for Reviewer

It seems I was a little bit too fast with the tag but I don't think we need to re-tag or create a new release.

There was a typo in the .pages file for the mkdocs release note generation.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from mossmaurice April 27, 2024 14:10
@elBoberido elBoberido self-assigned this Apr 27, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (625b2d0) to head (34d9d53).
Report is 1 commits behind head on release_2.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #2285      +/-   ##
===============================================
- Coverage        78.47%   78.46%   -0.01%     
===============================================
  Files              370      370              
  Lines            14217    14217              
  Branches          2060     2060              
===============================================
- Hits             11157    11156       -1     
  Misses            2377     2377              
- Partials           683      684       +1     
Flag Coverage Δ
unittests 77.70% <ø> (-0.01%) ⬇️
unittests_timing 15.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to re-tag or create a new release.

I agree, those changes can wait till a v2.0.7 ;)

@elBoberido elBoberido merged commit 6d357df into eclipse-iceoryx:release_2.0 Apr 28, 2024
@elBoberido elBoberido deleted the iox-2282-fix-website-for-v-2-0-6 branch April 28, 2024 12:00
@elBoberido elBoberido linked an issue Apr 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare v2.0.6 release for ROS2

2 participants