Declare id field as abstract#203
Merged
thjaeckle merged 1 commit intoeclipse-ditto:masterfrom Nov 15, 2022
vhdirk:TS2611
Merged
Declare id field as abstract#203thjaeckle merged 1 commit intoeclipse-ditto:masterfrom vhdirk:TS2611
thjaeckle merged 1 commit intoeclipse-ditto:masterfrom
vhdirk:TS2611
Conversation
Signed-off-by: Dirk Van Haerenborgh <[email protected]>
Member
|
Thanks for providing the fix, @vhdirk I would like to provide not too many bugfix releases and my TS knowledge is quite limited |
Contributor
Author
|
@thjaeckle I've just built and tested this against our application. I am happy to report this fully works as expected :) |
thjaeckle
approved these changes
Nov 15, 2022
Member
thjaeckle
left a comment
thjaeckle
left a comment
There was a problem hiding this comment.
Awesome, a thousand thanks 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202
Signed-off-by: Dirk Van Haerenborgh [email protected]