Skip to content

Adds a ClientReconnectingException which is thrown if the client is attempting a reconnect while a message should be sent.#201

Merged
jokraehe merged 3 commits intoeclipse-ditto:masterfrom
bosch-io:bugfix/reconnect-behaviour
Oct 4, 2022
Merged

Adds a ClientReconnectingException which is thrown if the client is attempting a reconnect while a message should be sent.#201
jokraehe merged 3 commits intoeclipse-ditto:masterfrom
bosch-io:bugfix/reconnect-behaviour

Conversation

@kalinkostashki
Copy link
Contributor

Prior the sender of a message only got clues about dropped messages due to reconnect in the clients logs, but couldn't handle this case in code.

The ClientReconnectingException can be handled by the sender and an optional buffering/ retrying strategy can be implemented.
In methods returning a CompletionStage the stage will complete exceptionally conatining the error, in other methods the exception is thrown and has to be catched for custom handling.

DerSchwilk and others added 2 commits September 30, 2022 10:47
…ttempting a reconnect while a message should be sent.

Prior the sender of a message only got clues about dropped messages due to reconnect in the clients logs, but couldn't handle this case in code.

The ClientReconnectingException can be handled by the sender and an optional buffering/ retrying strategy can be implemented.
In methods returning a CompletionStage the stage will complete exceptionally conatining the error, in other methods the exception is thrown and has to be catched for custom handling.

Co-authored-by: Kalin Kostashki <[email protected]>
Signed-off-by: David Schwilk <[email protected]>
Signed-off-by: Kalin Kostashki <[email protected]>
Copy link
Contributor

@DerSchwilk DerSchwilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Co-authored-by: Kalin Kostashki <[email protected]>
Signed-off-by: David Schwilk <[email protected]>
@jokraehe jokraehe merged commit 7310229 into eclipse-ditto:master Oct 4, 2022
@jokraehe jokraehe deleted the bugfix/reconnect-behaviour branch October 4, 2022 06:12
@thjaeckle thjaeckle added this to the 3.1.0 milestone Oct 4, 2022
@thjaeckle thjaeckle added the java label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants