feat: reviewing pull requests blog post #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkwon17
commented
Feb 10, 2022
| {empty} | ||
|
|
||
| === How can maintainers set up their projects to use {prod}? | ||
| === How can maintainers set up their projects to use {prod}? [[set-up-project]] |
Contributor
Author
There was a problem hiding this comment.
[[set-up-project]] was added so that this section can be linked here:
blog/_posts/2022-02-09-reviewing-pull-requests.adoc
Lines 21 to 23 in 0f35423
dkwon17
force-pushed
the
reviewing-pull-requests
branch
from
0f35423 to
ef34674
Compare
Member
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
Member
ibuziuk
left a comment
ibuziuk
left a comment
There was a problem hiding this comment.
Great article, really like it
the only thing is that with che-incubator organization has enabled OAuth App access restrictions it is not possible to approve / merge PRs from IDE. I think we should consider disabling this restriction
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
ibuziuk
reviewed
Feb 11, 2022
dkwon17
force-pushed
the
reviewing-pull-requests
branch
from
ef34674 to
abf3c7a
Compare
Contributor
Author
|
@ibuziuk thank you for the review, I have pushed the latest changes. |
ibuziuk
approved these changes
Feb 11, 2022
Member
ibuziuk
left a comment
ibuziuk
left a comment
There was a problem hiding this comment.
Thanks, David
could you please update the file so that the publication date will be Feb 16th
Would be great to have it published on the hump day next week 👍
ibuziuk
reviewed
Feb 11, 2022
dkwon17
force-pushed
the
reviewing-pull-requests
branch
2 times, most recently
from
8f144db to
bb665aa
Compare
Signed-off-by: David Kwon <[email protected]>
dkwon17
force-pushed
the
reviewing-pull-requests
branch
from
bb665aa to
8304834
Compare
Contributor
Author
Updated to Feb 16 👍 |
themr0c
approved these changes
Feb 16, 2022
deerskindoll
approved these changes
Feb 16, 2022
Contributor
|
Is it OK to merge with the ECA failure? Else @dkwon17 would have to amend the commits in his branch to fix the email address. |
* editing writing style and punctuation Signed-off-by: Jana Vrbkova <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Ilya Buziuk <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Ilya Buziuk <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Ilya Buziuk <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Ilya Buziuk <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: David Kwon <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <[email protected]> * Update 2022-02-16-reviewing-pull-requests.adoc quick typo fix Co-authored-by: Ilya Buziuk <[email protected]> Co-authored-by: Fabrice Flore-Thébault <[email protected]> Co-authored-by: David Kwon <[email protected]>
dkwon17
force-pushed
the
reviewing-pull-requests
branch
from
679b42a to
3e3319e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes the blog post for: https://issues.redhat.com/browse/RHDEVDOCS-3522
Blog post preview: https://pr-check-23--che-blog.surge.sh/2022/02/16/@david.kwon-reviewing-pull-requests.html
Signed-off-by: David Kwon [email protected]