Resolve confusion about Makefile projects in wizards.

[ewaterlander]

The following confusions are resolved:

• To create a legacy non-managed project one had to select a "Managed Build" project.
• The label "Makefile Project" was used for both lecacy Managed Build and new Core Build Makefile projects.

After discussion in #1305 we came to the following renaming of labels in Makefile project wizards:

• Legacy projects, based on the Managed Build System (can be managed and non-managed), will be named "Classic C/C++" projects.

• Makefile projects based on the new Core Build System will be named "Core Makefile" projects.

Fixes #1149

[ewaterlander]

Hi @jonahgraham and @jld01 ,

would you like to review this change?

[github-actions]

Test Results

  585 files   -    34    585 suites   - 34   13m 52s ⏱️ - 22m 46s
9 939 tests  - 1 217  9 910 ✅  - 1 096  29 💤  - 120  0 ❌ ±0 
9 955 runs   - 1 194  9 926 ✅  - 1 075  29 💤  - 118  0 ❌ ±0 

Results for commit a122d65. ± Comparison against base commit 559c9a6.

This pull request removes 1217 tests.

org.eclipse.cdt.debug.gdbjtag.core.tests.jtagdevice.GDBJtagDeviceContributionTest ‑ testGdbJtagDeviceContribution
org.eclipse.cdt.debug.gdbjtag.core.tests.launch.GDBJtagLaunchTest ‑ testGdbJtagLaunch[gdb]
org.eclipse.cdt.debug.gdbjtag.core.tests.launch.GDBJtagLaunchTest ‑ testGdbJtagLaunch[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithQuotes[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithQuotes[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSpecialSymbols[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSpecialSymbols[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSymbols[gdb]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithSymbols[gdbserver]
org.eclipse.cdt.tests.dsf.gdb.tests.CommandLineArgsTest ‑ testSettingArgumentsWithTabs[gdb]
…

♻️ This comment has been updated with latest results.

[ewaterlander]

Hi @jonahgraham and @jld01 ,

I think the remaining errors are unrelated to my change.

[jonahgraham]

The change looks comprehensive to me and I will leave it for @jld01 to review some of the content as he has been intimately involved in the discussions of #1305 to get us to this point.

As for the build errors: 😢 I will figure out what is happening here, my guess is something changed in platform and this is the first commit to expose it. I am looking into it now and will rebase this change if needed.

[jonahgraham]

As for the build errors: 😢 I will figure out what is happening here, my guess is something changed in platform and this is the first commit to expose it. I am looking into it now and will rebase this change if needed.

The problem was not ☝️ - it was the build happened to be running while LSP4E was updating its snapshot:

cdt/releng/org.eclipse.cdt.target/cdt.target

Line 26 in 559c9a6

<repository location="https://download.eclipse.org/lsp4e/snapshots/" />

Build is green now.