Skip to content

refactor: migrate from bip39 to @scure/bip39 #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxwellward wants to merge 7 commits into
base: development
Choose a base branch
from
+352 −53
Open

refactor: migrate from bip39 to @scure/bip39 #3299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
061cb4b
refactor: migrate from bip39 to @scure/bip39
maxwellward Jan 15, 2026
622e747
fix(package.json): fix tests failing to due bip39 package compatability
maxwellward Jan 15, 2026
7b5a493
fix: fix js import extension
maxwellward Jan 15, 2026
4adcab3
fix: remove scure/bip39 from external rollup array
maxwellward Jan 15, 2026
c5a3322
fix(package.json): allow jest to transform js files
maxwellward Jan 15, 2026
2ac6dae
fix(package.json): fix transform config failing tests
maxwellward Jan 15, 2026
6ce8ee9
fix: fix integration tests failing due to missing .js extension on bi…
maxwellward Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions integration-tests/__tests__/sapling/sapling-batched-transactions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { CONFIGS } from '../../config';
import { InMemorySpendingKey, InMemoryViewingKey, SaplingToolkit, SaplingTransactionViewer } from '@taquito/sapling';
import BigNumber from 'bignumber.js';
import { singleSaplingStateContractJProtocol } from '../../data/single_sapling_state_contract_jakarta_michelson';
import * as bip39 from 'bip39';
import * as bip39 from '@scure/bip39';
import { wordlist } from '@scure/bip39/wordlists/english.js';

CONFIGS().forEach(({ lib, rpc, setup }) => {
const Tezos = lib;
Expand Down Expand Up @@ -45,14 +46,14 @@ CONFIGS().forEach(({ lib, rpc, setup }) => {
await saplingContractOrigination.confirmation();
saplingContract = await saplingContractOrigination.contract();

const mnemonic1: string = bip39.generateMnemonic();
const mnemonic1: string = bip39.generateMnemonic(wordlist);
inMemorySpendingKey1 = await InMemorySpendingKey.fromMnemonic(mnemonic1);
inMemoryViewingKey1 = await inMemorySpendingKey1.getSaplingViewingKeyProvider();
saplingToolkit1 = new SaplingToolkit({ saplingSigner: inMemorySpendingKey1 }, { contractAddress: saplingContract.address, memoSize }, new RpcReadAdapter(Tezos.rpc));
txViewer1 = await saplingToolkit1.getSaplingTransactionViewer();
paymentAddress1Index0 = (await inMemoryViewingKey1.getAddress(0)).address;

const mnemonic2: string = bip39.generateMnemonic();
const mnemonic2: string = bip39.generateMnemonic(wordlist);
inMemorySpendingKey2 = await InMemorySpendingKey.fromMnemonic(mnemonic2);
inMemoryViewingKey2 = await inMemorySpendingKey2.getSaplingViewingKeyProvider();
saplingToolkit2 = new SaplingToolkit({ saplingSigner: inMemorySpendingKey2 }, { contractAddress: saplingContract.address, memoSize }, new RpcReadAdapter(Tezos.rpc));
Expand Down
5 changes: 3 additions & 2 deletions integration-tests/__tests__/sapling/sapling-transactions-contract-with-single-state.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { CONFIGS } from '../../config';
import { InMemorySpendingKey, SaplingToolkit } from '@taquito/sapling';
import BigNumber from 'bignumber.js';
import { singleSaplingStateContractJProtocol } from '../../data/single_sapling_state_contract_jakarta_michelson';
import * as bip39 from 'bip39';
import * as bip39 from '@scure/bip39';
import { wordlist } from '@scure/bip39/wordlists/english.js';

CONFIGS().forEach(({ lib, rpc, setup, createAddress }) => {
const Tezos = lib;
Expand All @@ -28,7 +29,7 @@ CONFIGS().forEach(({ lib, rpc, setup, createAddress }) => {
saplingContract = await saplingContractOrigination.contract();

// Generate a spending key and an InMemorySpendingKey instance for Bob using a mnemonic
const mnemonic: string = bip39.generateMnemonic();
const mnemonic: string = bip39.generateMnemonic(wordlist);
bobInmemorySpendingKey = await InMemorySpendingKey.fromMnemonic(mnemonic);

// Instantiate an InMemorySpendingKey from a spending key for Alice
Expand Down
5 changes: 3 additions & 2 deletions integration-tests/__tests__/sapling/sapling-transactions-proof-using-proving-key.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { CONFIGS } from '../../config';
import { InMemorySpendingKey, SaplingToolkit, InMemoryProvingKey } from '@taquito/sapling';
import BigNumber from 'bignumber.js';
import { singleSaplingStateContractJProtocol } from '../../data/single_sapling_state_contract_jakarta_michelson';
import * as bip39 from 'bip39';
import * as bip39 from '@scure/bip39';
import { wordlist } from '@scure/bip39/wordlists/english.js';

CONFIGS().forEach(({ lib, rpc, setup }) => {
const Tezos = lib;
Expand All @@ -30,7 +31,7 @@ CONFIGS().forEach(({ lib, rpc, setup }) => {
saplingContract = await saplingContractOrigination.contract();

// Generate a spending key and an InMemorySpendingKey instance for Bob using a mnemonic
const mnemonic: string = bip39.generateMnemonic();
const mnemonic: string = bip39.generateMnemonic(wordlist);
bobInmemorySpendingKey = await InMemorySpendingKey.fromMnemonic(mnemonic);

// Instantiate an InMemorySpendingKey from a spending key for Alice
Expand Down
5 changes: 3 additions & 2 deletions integration-tests/__tests__/signer-mnemonic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { InMemorySigner } from '@taquito/signer';
import { TezosToolkit } from '@taquito/taquito';
import { CONFIGS } from '../config';
import * as Bip39 from 'bip39';
import * as bip39 from '@scure/bip39';
import { wordlist } from '@scure/bip39/wordlists/english.js';

CONFIGS().forEach(({ lib, rpc, setup }) => {
let Funder: TezosToolkit;
Expand All @@ -14,7 +15,7 @@ CONFIGS().forEach(({ lib, rpc, setup }) => {
let funderPKH: string;

beforeAll(async () => {
mnemonic = Bip39.generateMnemonic();
mnemonic = bip39.generateMnemonic(wordlist);
Funder = lib;
await setup();

Expand Down
19 changes: 17 additions & 2 deletions integration-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,29 @@
"@taquito/tzip12": "^24.0.1",
"@taquito/tzip16": "^24.0.1",
"@taquito/utils": "^24.0.1",
"@scure/bip39": "^2.0.1",
"bignumber.js": "^9.1.2",
"bip39": "3.1.0",
"blakejs": "^1.2.1"
},
"private": true,
"jest": {
"transform": {
".(ts|tsx)": "ts-jest"
"^.+\\.(ts|tsx|js|mjs)$": [
"ts-jest",
{
"useESM": true,
"tsconfig": {
"esModuleInterop": true,
"allowJs": true
}
}
]
},
"transformIgnorePatterns": [
"/node_modules/(?!(@scure/bip39|@noble/hashes|@scure/base)/.*)"
],
"moduleNameMapper": {
"^@scure/bip39/wordlists/english.js$": "<rootDir>/../node_modules/@scure/bip39/wordlists/english.js"
},
"testEnvironment": "node",
"testRegex": "(/__tests__/.*|\\.(test|spec))\\.(ts|tsx|js)$",
Expand Down
Loading
Loading