Fix report text duplication for brms models #509
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
report()output was duplicated multiple times for brms models, particularly when used in tidymodels workflows.Problem
When calling
report()on brmsfit objects, the same text would appear multiple times in the output, making the reports difficult to read and use.Root Cause
The issue occurred because brmsfit objects use mixed inheritance:
report_text.lmreport_parameters.stanregThis mismatch caused conflicts in the text assembly pipeline where stanreg-formatted parameters didn't integrate properly with the lm text framework, leading to duplication.
Solution
Added a dedicated
report_text.brmsfit()method that:Example
Changes
report_text.brmsfit()method inR/report.brmsfit.Rtests/testthat/test-brmsfit-duplication-fix.RValidation
Fixes #418.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.