Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Nov 7, 2018

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Have you got a rendered version just to double check the formatting?

@boegel
Copy link
Member Author

boegel commented Nov 14, 2018

@ocaisa Wasn't there yet because there was an issue with readthedocs, but it's there now, see https://boegel-eb.readthedocs.io/en/deprecated_ecs_tcs/Deprecated-easyconfigs.html


Using an easyconfig file or toolchain that was marked as deprecated results in a warning message like::

WARNING: Deprecated functionality, will no longer work in v4.0: easyconfig file '/home/example/test.eb' is marked as deprecated:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These blocks are being syntax highlighted (for Python I think). Not a sphinx expert but should be easy to switch off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would expect this to be easy to fix, turns out it's not...

With .. code:: none, the block is not displayed at all, with .. code:: text I'm still getting highlighting.

I'll keep poking at it, thanks for pointing this out, it indeed looks a bit silly this way...

@boegel boegel force-pushed the deprecated_ecs_tcs branch from 2778350 to 09ccdf7 Compare November 14, 2018 14:17
@ocaisa
Copy link
Member

ocaisa commented Nov 15, 2018

Seems to be ok now, if you're ok with it I can merge

@ocaisa
Copy link
Member

ocaisa commented Nov 15, 2018

According to https://stackoverflow.com/questions/44376893/selectively-disable-readthedocs-syntax-highlighting you also could have used
.. highlight:: none

@boegel
Copy link
Member Author

boegel commented Nov 15, 2018

@ocaisa Tried .. highlight:: none via http://rst.ninjs.org/, and it barfed on it...

Anyway, problem fixed indeed, good to go imho!

@ocaisa
Copy link
Member

ocaisa commented Nov 15, 2018

Yeah, I think it's a sphinx option as opposed to an rst option

@ocaisa ocaisa merged commit 0f7b225 into easybuilders:develop Nov 15, 2018
@boegel boegel deleted the deprecated_ecs_tcs branch November 15, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants