Enable flake8-comprehension code style check and fix issues #5043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
comprehensions
branch
from
6b84106 to
a99c475
Compare
E.g.: > C419 Unnecessary list comprehension in <any/all>() prevents short-circuiting - rewrite as a generator. See https://pypi.org/project/flake8-comprehensions
Flamefire
force-pushed
the
comprehensions
branch
from
a99c475 to
57a79b5
Compare
Flamefire
force-pushed
the
comprehensions
branch
from
57a79b5 to
148267c
Compare
boegel
reviewed
Nov 19, 2025
| returns the current threads name | ||
| """ | ||
| return threading.currentThread().getName() | ||
| return threading.current_thread().name |
Member
There was a problem hiding this comment.
Both currentThread() and getName() are deprecated, so makes sense to stop using those since they're bound to be removed at some point, see https://docs.python.org/3/library/threading.html#threading.current_thread and https://docs.python.org/3/library/threading.html#threading.Thread.getName
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pypi.org/project/flake8-comprehensions/ has various useful checks, most importantly:
I.e. things like
any([expensive_check(x) for x in collection])runs the check after processing the full collection instead of stopping after the first "match" which costs performance.To me the whole collection of checks look useful for performance and readability so enable them all.