Add templates for patch versions #5028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is used by some easyconfigs add `version_patch` and `version_minor_patch` templates similar to existing version templates. As some easyconfigs don't have patch versions don't define those templates in this case so access to/use of them fails.
Used for e.g. CUDA related ECs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is used by some easyconfigs add
version_patchandversion_minor_patchtemplates similar to existing version templates.As some easyconfigs don't have patch versions don't define those templates in this case so access to/use of them fails.
This avoids error-prone repetitions like
local_patch = version.split('.')[2]or'files/lcms/%s/' % '.'.join(version.split('.')[:2])The
major.minor.patchvariant is useful e.g. for CUDA related ECs, e.g. cuDNN 8.8.0.121 where the download path contains only 8.8.0