Add templates for source with just version numbers (like VERSION_TAR_GZ and V_VERSION_TAR_GZ)
#5025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @Flamefire who i think has explicitly requested this before. |
Flamefire
reviewed
Oct 12, 2025
Contributor
Flamefire
left a comment
Flamefire
left a comment
There was a problem hiding this comment.
Thanks for that
One alternative to VVERSION_<ext> could be V_VERSION_<ext> which makes it easier to see the "v" while being a single char longer
And maybe we should keep the SOURCE_ suffix at least for discoverability among the other templates
Co-authored-by: Alexander Grund <[email protected]>
boegel
requested changes
Nov 19, 2025
Co-authored-by: Kenneth Hoste <[email protected]>
boegel
requested changes
Nov 21, 2025
Co-authored-by: Kenneth Hoste <[email protected]>
boegel
changed the title
VERSION_TAR_GZ and V_VERSION_TAR_GZ)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding templates for the common
%(version)s.tar.gzandv%(version)s.tar.gzsources.E.g.
VERSION_TAR_GZVVERSION_ZIPI didn't know a better option but to append an extra V for the second option.
I haven't tested anything yet, throwing it out there to gauge the response first.