make RPATH wrapper script not add RPATH (linking) flags when -c flag specified
#4981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the compiler is invoked with the `-c` flag, the linker is not run. In this case, the RPATH linker flags are useless. Although they are normally ignored, adding them has shown to cause problems in some cases, e.g. with Intel + Meson: easybuilders/easybuild-easyconfigs#20262 The behavior of the `rpath_args.py` script has been modified to not add RPATH flags when the `-c` flag is detected. Moreover, it is now able to detect any RPATH flag that may have been added explicitly by the user/build system. Tests have been updated to check these scenarios. Fixes easybuilders/easybuild-easyconfigs#23031 Fixes easybuilders#4979
2 tasks
boegel
changed the title
-c flag specified-c flag specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the compiler is invoked with the
-cflag, the linker is not run.In this case, the RPATH linker flags are useless. Although they are
normally ignored, adding them has shown to cause problems in some cases,
e.g. with Intel + Meson:
easybuilders/easybuild-easyconfigs#20262
The behavior of the
rpath_args.pyscript has been modified so that RPATHflags are not added when the
-cflag is detected.Moreover, it is now able to detect and process any RPATH flag that may have
been added explicitly by the user/build system.
Tests have been updated to check all these possible scenarios.
Fixes easybuilders/easybuild-easyconfigs#23031
Fixes #4979