Skip to content

add total iteration count to trace output #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 7 commits into from
Jul 3, 2025
Merged

add total iteration count to trace output #4919

boegel merged 7 commits into from
Jul 3, 2025

Conversation

@smoors
Copy link
Contributor

@smoors smoors commented Jun 12, 2025 •
edited
Loading

also show the iteration number (starting at 1) instead of iteration index (starting at 0)

before:

== starting iteration #0 ...
== starting iteration #1 ...
== starting iteration #2 ...

after

== starting iteration 1/3 ...
== starting iteration 2/3 ...
== starting iteration 3/3 ...

boegel
boegel reviewed Jun 13, 2025
View reviewed changes
@boegel boegel added this to the next release (5.1.1?) milestone Jun 13, 2025
boegel
boegel requested changes Jun 18, 2025
View reviewed changes
smoors and others added 4 commits June 18, 2025 12:44
@smoors @boegel
drop number
2097b87 
Co-authored-by: Kenneth Hoste <[email protected]>
@smoors @boegel
drop number
f2457b6 
Co-authored-by: Kenneth Hoste <[email protected]>
@smoors @boegel
drop number
b65d97e 
Co-authored-by: Kenneth Hoste <[email protected]>
@smoors @boegel
drop number
3e90216 
Co-authored-by: Kenneth Hoste <[email protected]>
boegel
boegel approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit edb4e06 into easybuilders:develop Jul 3, 2025
37 checks passed
@smoors smoors deleted the num_iter branch July 3, 2025 07:12
@branfosj branfosj mentioned this pull request Jul 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@smoors @boegel