only wait in download_file when it makes sense to wait (when HTTP status 429 was found)
#4880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tus 429 was found)
ocaisa
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #4870 (which are no longer relevant for
--from-prand--from-commitwith the changes in #4878) lead to massively longer test suite run times, because there are a couple of tests that deliberate involve trying to download non-existing files.Waiting before trying again in
download_filereally only makes sense when a429HTTP status was returned ("Too many requests"), since if the specified URL simply doesn't exist, no amount of waiting is likely to result in a successful download in the end.