Fix is_patch_for for patch dicts
#4865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function only handled strings and lists but not the dict patch format. This caused a hard error because `p % templates` doesn't work when `p` is a dict --> `TypeError`. Factor out function to extract name of patchspec and use it. This avoids the 2 places where the bug was and simplifies the function.
Flamefire
force-pushed
the
fix-patch-for
branch
from
a52fe60 to
1af5741
Compare
Checking the regular log there is no indication when an easyconfig was skipped and hence wasn't found for the patch and using `--debug` just for that produces so much output that it is very hard to find this single entry.
Flamefire
force-pushed
the
fix-patch-for
branch
from
1af5741 to
64ad44b
Compare
Contributor
|
Merging, thanks @Flamefire ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function only handled strings and lists but not the dict patch
format.
This caused a hard error because
p % templatesdoesn't work whenpis a dict -->
TypeError.Factor out function to extract name of patchspec and use it.
This avoids the 2 places where the bug was and simplifies the function.