move EasyBlock.expand_module_search_path into ModuleEnvironmentVariable.expand_paths
#4859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable.expand_paths
…ariable_expand_paths
boegel
changed the title
EasyBlock.expand_module_search_path into ModuleEnvironmentVariable.expand_paths
lexming
force-pushed
the
modenvvar-expand-paths
branch
from
2631db1 to
8f0135a
Compare
…d by EasyBlock.module_load_environment.expand_paths
mark `EasyBlock.expand_module_search_path` as removed, has been replaced by `EasyBlock.module_load_environment.expand_paths`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4858 with code cleanup.
The logic in
EasyBlock.expand_module_search_pathis very much independent of the EasyBlock itself, only needing the path to the installation directory. Therefore it is simpler to move that code intoModuleEnvironmentVariable, where the attributes of the environment variable are known (e.g. its type) and closer to the rest of the code handling them.