modernize tests that require GitHub token #4776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
reviewed
Mar 2, 2025
boegel
requested changes
Mar 2, 2025
test/framework/sandbox/easybuild/easyblocks/generic/perlbundle.py
Outdated
Show resolved
Hide resolved
branfosj
commented
Mar 2, 2025
test/framework/sandbox/easybuild/easyblocks/o/openssl_wrapper.py
Outdated
Show resolved
Hide resolved
boegel
reviewed
Mar 2, 2025
test/framework/easyconfig.py
Outdated
| bat_ec_fn = 'bat-0.3.3-intel-2017b-Python-3.6.3.eb' | ||
| bat_patch_fn = 'bat-0.3.3-fix-pyspark.patch' | ||
| # see https://github.com/easybuilders/easybuild-easyconfigs/pull/22365 | ||
| from_pr = 22365 |
Member
There was a problem hiding this comment.
@branfosj This is not the best pick, since the contents of this specific PR will change once easybuilders/easybuild-easyconfigs#22345 is merged...
Can we find another one?
boegel
reviewed
Mar 2, 2025
| 'pr_target_account': gh.GITHUB_EB_MAIN, | ||
| }) | ||
|
|
||
| # TODO: no 5.x PRs for new easyblocks |
Member
There was a problem hiding this comment.
Once the 5.0.x branch is collapsed into develop, this should no longer be a problem?
boegel
reviewed
Mar 2, 2025
test/framework/options.py
Outdated
| # test use of --copy-ec with --from-pr to the current working directory | ||
| cwd = change_dir(test_working_dir) | ||
| args = ['--copy-ec', '--from-pr', '8007'] | ||
| args = ['--copy-ec', '--from-pr', '22365'] |
Member
There was a problem hiding this comment.
not ideal, contents of this PR will change once it gets synced with target branch after easybuilders/easybuild-easyconfigs#22345 gets merged...
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_github_fetch_easyconfigs_from_prtest_github_copy_ec_from_prtest_github_fetch_easyblocks_from_prtest_det_copy_ec_specstest_github_from_pr_token_logtest_github_add_pr_labelstest_github_det_easyconfig_paths_from_prtest_github_from_pr_listed_ecstest_github_from_pr_xtest_github_review_prtest_github_fetch_files_from_pr_cachetest_github_merge_prtest_github_from_prtest_github_xxx_include_easyblocks_from_pr