Adapt module show command run to cope with non-zero exit code for non-existing module (required for Environment Modules v5.5+ and Lmod 8.7.56+)
#4739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "module show" command is used by ModulesTool "exist" method to test the existence of a modulefile. Running "module show" against a non-existing modulefile will make modulecmd.tcl script to produce a non-zero exit code starting Modules v5.5. With this change, the exit code check when running "module show" is disabled. It should not harm the module existence check as it relies on the analysis of the obtained stderr output. Note that Lmod (as of version 8.7.55) does not set a non-zero exit code when running "module show" against a non-existing modulefile when LMOD_QUIET environment variable is set. If this behavior is changed in the future, this commit will also benefit to Lmod.
Starting Environment Modules v5.5, a non-zero exit code is set by modulecmd.tcl when trying to load a non-existing module.
xdelaruelle
force-pushed
the
modules-5.5
branch
from
2981e02 to
d257b87
Compare
Member
|
Looks OK, but I want to verify a bit better than we're not relying on the exit code in other places, where the |
boegel
changed the title
module show command run to cope with Environment Modules v5.5+module show command run to cope with non-zero exit code for non-existing module (required for Environment Modules v5.5+ and Lmod 8.7.56+)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
module showcommand is used by ModulesToolexistmethod to test the existence of a modulefile. Runningmodule showagainst a non-existing modulefile will makemodulecmd.tclscript to produce a non-zero exit code starting Modules v5.5.With this change, the exit code check when running
module showis disabled. It should not harm the module existence check as it relies on the analysis of the obtained stderr output.Note that Lmod (as of version 8.7.55) does not set a non-zero exit code when running
module showagainst a non-existing modulefile whenLMOD_QUIETenvironment variable is set. If this behavior is changed in the future, this change will also benefit to Lmod.