fix copy_file with a folder as the target
#4609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This use case comes up with e.g. `--copy-ec /tmp`. The existing code will see that `/tmp` exists and has a different UID and hence will use `shutil.copy_file` which expects the target to not be a folder. It hence fails with "[Errno 21] Is a directory" Use `shutil.copy` as was likely intended anyway.
`shutil.copy` tries to change permissions which isn't allowed in the case where it is used. As we already made sure the target is a file we can use `shutil.copyfile`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use case comes up with e.g.
--copy-ec /tmp.The existing code will see that
/tmpexists and has a different UID and hence will useshutil.copyfilewhich expects the target to not be a folder. It hence fails with "[Errno 21] Is a directory"Check for that case and make sure the target is always a file, not a directory.