improve error messages for empty easyconfigs #4603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we get:
That isn't exactly clear. So improve in 2 steps:
Noneor error iferror_on_missing_easyblockis setPossible improvement: Pass
error_on_missing_easyblockin the EasyConfig constructor and use an empty dict asextra_optionsif noeasyblock_classwas found, i.e.self.extra_options = easyblock_class.extra_options() if easyblock_class else {}This will error later in the parser which doesn't find the required keys like "name".
Not sure if that error ("missing required keys: name, ...") is cleaner than "No easyblock found as neither name nor easyblock were specified" though.