Skip to content

enhance --fix-deprecated-easyconfigs to also switch to alternate names of easyconfig parameters, templates, constants #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
boegel wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

enhance --fix-deprecated-easyconfigs to also switch to alternate names of easyconfig parameters, templates, constants #4547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions easybuild/framework/easyconfig/easyconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2508,10 +2508,23 @@ def fix_deprecated_easyconfigs(paths):
# fix use of local variables with a name other than a single letter or 'local_*'
ec = EasyConfig(path, local_var_naming_check=LOCAL_VAR_NAMING_CHECK_LOG)
for key in ec.unknown_keys:
regexp = re.compile(r'\b(%s)\b' % key)
ectxt = regexp.sub(LOCAL_VAR_PREFIX + key, ectxt)
regex = re.compile(r'\b(%s)\b' % key)
ectxt = regex.sub(LOCAL_VAR_PREFIX + key, ectxt)
fixed = True

# replace renamed easyconfig parameters
for (new_param, old_param) in ALTERNATE_PARAMETERS.items():
# top-level easyconfig parameters
regex = re.compile(rf'^{old_param}\s*=\s*', re.M)
if regex.search(ectxt):
ectxt = regex.sub(rf'{new_param} = ', ectxt)
fixed = True
# parameters set for extensions
regex = re.compile(rf"""^(\s*["']){old_param}(["']\s*:\s*)""", re.M)
if regex.search(ectxt):
ectxt = regex.sub(rf"\1{new_param}\2", ectxt)
fixed = True

if fixed:
fixed_cnt += 1
backup_path = find_backup_name_candidate(path + '.orig')
Expand Down