add new get_cwd function to tools.filetools to retrieve current working directory
#4525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…http_header_fields_urlpat
boegel
requested changes
May 4, 2024
Member
boegel
left a comment
boegel
left a comment
There was a problem hiding this comment.
some minor suggestions, looks good overall!
boegel
changed the title
get_cwd function to tools.filetools to retrieve current working directory
Co-authored-by: Kenneth Hoste <[email protected]>
boegel
requested changes
May 22, 2024
move `CWD_NOTFOUND_ERROR` constant to `tools.build_log`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition of a wrapper around
os.getcwdto be able to improve error reporting whenever it fails.This PR includes unit tests for the new method and also adapts all current uses of
os.getcwdto the newget_cwd.Motivation is to improve error reporting on issues such as those described in #4390