Skip to content

eliminate duplicate multideps from generated module files #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 2 commits into from
Dec 6, 2023
Merged

eliminate duplicate multideps from generated module files #4386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95e8c48
When combining multi_deps with iterative builds, it generates a list …
mboisson Nov 21, 2023
3714b8c
Use nub instead of set to preserve order
mboisson Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions easybuild/tools/module_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
from easybuild.tools.filetools import convert_name, mkdir, read_file, remove_file, resolve_path, symlink, write_file
from easybuild.tools.modules import ROOT_ENV_VAR_NAME_PREFIX, EnvironmentModulesC, Lmod, modules_tool
from easybuild.tools.py2vs3 import string_type
from easybuild.tools.utilities import get_subclasses, quote_str
from easybuild.tools.utilities import get_subclasses, nub, quote_str


_log = fancylogger.getLogger('module_generator', fname=False)
Expand Down Expand Up @@ -666,7 +666,7 @@ def _generate_help_text(self):
if multi_deps:
compatible_modules_txt = '\n'.join([
"This module is compatible with the following modules, one of each line is required:",
] + ['* %s' % d for d in multi_deps])
] + ['* %s' % d for d in nub(multi_deps)])
lines.extend(self._generate_section("Compatible modules", compatible_modules_txt))

# Extensions (if any)
Expand Down