change run_shell_cmd to store command output in temporary file(s) by default + pass RunShellCmdResult instance to RunShellCmdError
#4356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
force-pushed
the
run_shell_cmd_out_files
branch
from
09d3dbc to
05374ad
Compare
…odules.py and tools/systemtools.py
…olders in run_shell_cmd
boegel
changed the title
run_shell_cmd to always store command output in temporary file(s) + pass RunShellCmdResult instance to RunShellCmdErrorrun_shell_cmd to store command output in temporary file(s) by default + pass RunShellCmdResult instance to RunShellCmdError
…o individual fields
lexming
reviewed
Nov 8, 2023
Contributor
lexming
left a comment
lexming
left a comment
There was a problem hiding this comment.
Looks good, passing the output and error file pointers to RunShellCmdError from the outside will avoid the duplicate logs. I have a minor nitpick suggestion :)
…ShellCmdError.print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because i) tests still fail, ii) it sits on top of #4351 which should get merged first