-
Notifications
You must be signed in to change notification settings - Fork 217
don't use FileExistsError in mkdir function (doesn't exist in Python 2.7)
#4328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Same as the Python3 implementation which has a comment: > Cannot rely on checking for EEXIST, since the operating system could give priority to other errors like EACCES or EROFS
Use the new py2vpy3.makedirs compat layer.
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@Flamefire Hmm, new test fails: edit: fixed in 40f9fe7 |
FileExistsErrorFileExistsError in mkdir function
…tion if directory already exists, so the check passes with both Python 2 and 3
|
We overlooked this because we stopped running the tests on top of Python 2 in #4267, ugh... |
Your fix works, thanks! For reference: "17" is |
FileExistsError in mkdir functionFileExistsError in mkdir function (doesn't exist in Python 2.7)
|
I've opened #4333 to bring back running the test suite with Python 2.7... |
Follow-up to #4300 which introduced a Python3 class
Fix by introducing a Python2 implementation and using that.