Skip to content

don't fail in mkdir if path gets created while processing it #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocaisa merged 2 commits into from
Jul 24, 2023
Merged

don't fail in mkdir if path gets created while processing it #4300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d43ae94
Don't fail `mkdir` if path gets created while processing it
Flamefire Jul 24, 2023
7e0d42d
Fix spelling
Flamefire Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions easybuild/tools/filetools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1921,6 +1921,12 @@ def mkdir(path, parents=False, set_gid=None, sticky=None):
os.makedirs(path)
else:
os.mkdir(path)
except FileExistsError as err:
if os.path.exists(path):
# This may happen if a parallel build creates the directory after we checked for its existence
_log.debug("Directory creation aborted as it seems it was already created: %s", err)
else:
raise EasyBuildError("Failed to create directory %s: %s", path, err)
except OSError as err:
raise EasyBuildError("Failed to create directory %s: %s", path, err)

Expand Down