Skip to content

remove deprecated functionality from filetools #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 1 commit into from
Sep 6, 2023
Merged

remove deprecated functionality from filetools #4275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions easybuild/tools/filetools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,7 +1727,7 @@ def convert_name(name, upper=False):


def adjust_permissions(provided_path, permission_bits, add=True, onlyfiles=False, onlydirs=False, recursive=True,
group_id=None, relative=True, ignore_errors=False, skip_symlinks=None):
group_id=None, relative=True, ignore_errors=False):
"""
Change permissions for specified path, using specified permission bits

Expand All @@ -1744,11 +1744,6 @@ def adjust_permissions(provided_path, permission_bits, add=True, onlyfiles=False
and directories (if onlyfiles is False) in path
"""

if skip_symlinks is not None:
depr_msg = "Use of 'skip_symlinks' argument for 'adjust_permissions' is deprecated "
depr_msg += "(symlinks are never followed anymore)"
_log.deprecated(depr_msg, '4.0')

provided_path = os.path.abspath(provided_path)

if recursive:
Expand Down Expand Up @@ -2078,13 +2073,6 @@ def path_matches(path, paths):
return False


def rmtree2(path, n=3):
"""Wrapper around shutil.rmtree to make it more robust when used on NFS mounted file systems."""

_log.deprecated("Use 'remove_dir' rather than 'rmtree2'", '5.0')
remove_dir(path)


def find_backup_name_candidate(src_file):
"""Returns a non-existing file to be used as destination for backup files"""

Expand Down Expand Up @@ -2191,11 +2179,6 @@ def cleanup(logfile, tempdir, testing, silent=False):
print_msg(msg, log=None, silent=testing or silent)


def copytree(src, dst, symlinks=False, ignore=None):
"""DEPRECATED and removed. Use copy_dir"""
_log.deprecated("Use 'copy_dir' rather than 'copytree'", '4.0')


def encode_string(name):
"""
This encoding function handles funky software names ad infinitum, like:
Expand Down