Skip to content

add warning whenever a value with a template is replaced by a value without template #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mboisson wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

add warning whenever a value with a template is replaced by a value without template #4212

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bf7a48
added a test to raise an EasyBuildError if a value with a template is…
mboisson Feb 9, 2023
04148e8
appeasing hound
mboisson Feb 9, 2023
e1308a5
handle non-string elements
mboisson Feb 9, 2023
c3da536
maybe raising an EasyBuildError is too strong. Replacing with a warni…
mboisson Feb 9, 2023
2e53575
correct comment
mboisson Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions easybuild/framework/easyconfig/easyconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,6 +1780,10 @@ def get_ref(self, key):
def __setitem__(self, key, value):
"""Set value of specified easyconfig parameter (help text & co is left untouched)"""
if key in self._config:
# raise an error if we are replacing a value with templates by a value with templates resolved
if "%(" in str(self._config[key][0]) and "%(" not in str(value):
self.log.warning("Replacing value of templated parameter '%s' with a value with templates"
"resolved. Old value: %s, new value: %s" % (key, self._config[key][0], value))
self._config[key][0] = value
else:
raise EasyBuildError("Use of unknown easyconfig parameter '%s' when setting parameter value to '%s'",
Expand Down