replace more usages of assertTrue/False in tests #4205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
test-asserts
branch
2 times, most recently
from
df6f14f to
69e06ba
Compare
Flamefire
force-pushed
the
test-asserts
branch
from
69e06ba to
2aae57c
Compare
jfgrimm
requested changes
Feb 21, 2023
As suggested in review by @jfgrimm
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Going in, thanks @Flamefire! |
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found yet another bug in the tests in
test_pypi_source_urls:This test will always succeed,
assertInwas intended.Hence I did another RegEx-powered Search&Replace and introduced
assert(Not)Existsto replace the most common use ofassertTrue/Falsewhich also fixes a few bugs in error messages.