-
Notifications
You must be signed in to change notification settings - Fork 217
enforce absolute paths as start dir of extensions #4196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2023
ocaisa
reviewed
Jan 26, 2023
ocaisa
reviewed
Jan 26, 2023
…nEasyBlock Co-authored-by: ocaisa <[email protected]>
ocaisa
requested changes
Jan 26, 2023
ocaisa
reviewed
Jan 27, 2023
ocaisa
approved these changes
Jan 27, 2023
Member
ocaisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
self.start_dirin regular packages is always an absolute path. So it can be easily used in easyblocks regardles ofcwdin the same way asself.installdirandself.builddir.However,
self.start_dirof extensions is eitherNoneor the path set inself.cfg['start_dir']of the extension, which is always a relative path.This PR updates
ExtensionEasyBlock._set_start_dirto always defineself.start_diras an absolute path. Standardizing its form across packages and extensions. The resulting start dir will be set according to the following preference order:self.start_diris an absolute path and exists it will be used as isself.ext_dirwithself.start_dirRPackagesas it prepends stuff toself.start_dir:fixed in use start dir of extension to install R packages easybuild-easyblocks#2867