Skip to content

check type of versionsuffix value in det_full_ec_version, and raise useful error message if it's not a string #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akesandgren merged 1 commit into from
Feb 15, 2023
Merged

check type of versionsuffix value in det_full_ec_version, and raise useful error message if it's not a string #4184

akesandgren merged 1 commit into from
Feb 15, 2023

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jan 18, 2023

fixes #4181

@boegel boegel added the bug fix label Jan 18, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Jan 18, 2023
@boegel boegel mentioned this pull request Jan 18, 2023
Closed
@boegel boegel requested a review from bartoldeman February 1, 2023 07:32
@boegel boegel removed the request for review from bartoldeman February 15, 2023 14:05
akesandgren
akesandgren approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

akesandgren commented Feb 15, 2023

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 4e88b2e into easybuilders:develop Feb 15, 2023
@boegel boegel deleted the improve_error_faulty_dep_spec branch February 17, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

Accidentally using ('CUDA', version, SYSTEM) instead of ('CUDA', version, '', SYSTEM) leads to cryptic errors

2 participants

@boegel @akesandgren