Skip to content

print deprecation warning with running EasyBuild with Python 2 #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocaisa merged 2 commits into from
Dec 7, 2022
Merged

print deprecation warning with running EasyBuild with Python 2 #4136

ocaisa merged 2 commits into from
Dec 7, 2022

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 7, 2022 •
edited
Loading

This makes EasyBuild print a big fat deprecation warning when it's being run with Python 2:

$ eb --version


!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!! Running EasyBuild with Python v2.x is deprecated, found Python v2.7.18.                     !!!
!!! Support for running EasyBuild with Python v2.x will be removed in EasyBuild v5.0.           !!!
!!!                                                                                             !!!
!!! It is strongly recommended to start using Python v3.x for running EasyBuild,                !!!
!!! see https://docs.easybuild.io/en/latest/Python-2-3-compatibility.html for more information. !!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

People can silence this warning at their own risk via the --silence-deprecation-warnings configuration setting, by using python2 as a value.

@boegel boegel added the change label Dec 7, 2022
@boegel boegel added this to the next release (4.7.0) milestone Dec 7, 2022
@easybuilders easybuilders deleted a comment from boegelbot Dec 7, 2022
ocaisa
ocaisa approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa enabled auto-merge December 7, 2022 16:35
@ocaisa ocaisa merged commit a304b66 into easybuilders:develop Dec 7, 2022
@boegel boegel deleted the depr_py2 branch December 8, 2022 13:23
@boegel boegel changed the title deprecate support for running EasyBuild with Python 2 print deprecation warning with running EasyBuild with Python 2 Jan 8, 2023
@boegel boegel mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @ocaisa