Skip to content

only run GitHub tests when testing with Lua module syntax, to avoid hitting GitHub rate limit when running tests #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
migueldiascosta merged 1 commit into from
Jan 23, 2022
Merged

only run GitHub tests when testing with Lua module syntax, to avoid hitting GitHub rate limit when running tests #3938

migueldiascosta merged 1 commit into from
Jan 23, 2022

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jan 23, 2022

No description provided.

@boegel boegel added this to the 4.5.2 milestone Jan 23, 2022
migueldiascosta
migueldiascosta approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

migueldiascosta commented Jan 23, 2022

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 54b1e90 into easybuilders:4.5.x Jan 23, 2022
@boegel boegel deleted the github_tests_lua_syntax branch January 24, 2022 07:35
@boegel boegel mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

bug fix tests

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @migueldiascosta