Skip to content

fix broken test by taking into account changed error raised by Python 3.9.7 when copying directory via shutil.copyfile #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akesandgren merged 1 commit into from
Sep 17, 2021
Merged

fix broken test by taking into account changed error raised by Python 3.9.7 when copying directory via shutil.copyfile #3840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/framework/filetools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,9 @@ def test_copy_file(self):

# clean error when trying to copy a directory with copy_file
src, target = os.path.dirname(to_copy), os.path.join(self.test_prefix, 'toy')
self.assertErrorRegex(EasyBuildError, "Failed to copy file.*Is a directory", ft.copy_file, src, target)
# error message was changed in Python 3.9.7 to "FileNotFoundError: Directory does not exist"
error_pattern = "Failed to copy file.*(Is a directory|Directory does not exist)"
self.assertErrorRegex(EasyBuildError, error_pattern, ft.copy_file, src, target)

# test overwriting of existing file owned by someone else,
# which should make copy_file use shutil.copyfile rather than shutil.copy2
Expand Down