Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 23, 2020

This will come in useful for software like AOCC and Intel's oneAPI that require accepting an End User License Agreement (EULA) on installation...

@boegel boegel added this to the next release (4.3.3?) milestone Dec 23, 2020
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!


error_lines.extend([
"You should either:",
"- add --accept-eula-for=%(name)s to the 'eb' command;",
Copy link
Member

@migueldiascosta migueldiascosta Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel either this should say --accept-eula= instead of --accept-eula-for=, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right, I renamed the option to --accept-eula while working on it...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #3536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants